Merged
Conversation
SantiagoPittella
added
the
no changelog
SantiagoPittella
force-pushed
the
santiagopittella-fix-ntx-builder-paginated-query
branch
from
84828a5 to
8030090
Compare
igamigo
approved these changes
Mar 31, 2026
Collaborator
igamigo
left a comment
igamigo
left a comment
There was a problem hiding this comment.
LGTM! I wonder if all of these minor details and inconsistencies are calling for building some of the functionality into a pagination helper structure or something similar.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1868